From 4a8f7dc7e9f3f57f08cca9ca2de19214cbe4dc77 Mon Sep 17 00:00:00 2001 From: Bernhard Schommer Date: Thu, 9 Feb 2017 15:54:31 +0100 Subject: Extended unused vars check for params. The test now also checks whether the parameter are used at all in the function body. Bug 19872 --- cparser/Checks.ml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'cparser/Checks.ml') diff --git a/cparser/Checks.ml b/cparser/Checks.ml index 5ce51aba..dc08e254 100644 --- a/cparser/Checks.ml +++ b/cparser/Checks.ml @@ -167,5 +167,7 @@ let unused_variables p = | Gfundef fd -> let dec_env,used_env = vars_used_stmt (IdentMap.empty,IdentSet.empty) fd.fd_body in IdentMap.iter (fun id loc -> if not (IdentSet.mem id used_env) then - warning loc Unused_variable "unused variable '%s'" id.name) dec_env + warning loc Unused_variable "unused variable '%s'" id.name) dec_env; + List.iter (fun (id,_) -> if not (IdentSet.mem id used_env) then + warning g.gloc Unused_parameter "unused parameter '%s'" id.name) fd.fd_params | _ -> ()) p -- cgit